Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 8, 2025

PR-Codex overview

This PR focuses on exporting a constant array of USAGE_V2_SOURCES in the packages/service-utils/src/core/usageV2.ts file and defining a corresponding type UsageV2Source.

Detailed summary

  • Added a constant USAGE_V2_SOURCES that includes the sources: bundler, engine, insight, nebula, rpc, sdk, storage, wallet.
  • Defined a type UsageV2Source based on the USAGE_V2_SOURCES array.
  • Updated the getTopicName function to utilize the UsageV2Source type.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 8, 2025 03:58
@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2025

🦋 Changeset detected

Latest commit: 7130c62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:11am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:11am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:11am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:11am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:11am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 743 ms (+72.68% 🔺) 1.7 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 954 ms (-2.39% 🔽) 3.4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 150 ms (+247.59% 🔺) 262 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 59 ms (+495.95% 🔺) 69 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 207 ms (+211.84% 🔺) 593 ms

@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (e50d77d) to head (7130c62).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6206      +/-   ##
==========================================
- Coverage   56.76%   56.76%   -0.01%     
==========================================
  Files        1161     1161              
  Lines       64261    64261              
  Branches     5197     5194       -3     
==========================================
- Hits        36479    36478       -1     
- Misses      27053    27054       +1     
  Partials      729      729              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e50d77d
packages 54.94% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants